Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(account_page_header_dropdown_balances), fixes #940 #941

Closed
wants to merge 3 commits into from
Closed

fix(account_page_header_dropdown_balances), fixes #940 #941

wants to merge 3 commits into from

Conversation

elmurci
Copy link

@elmurci elmurci commented Feb 17, 2024

High Level Overview of Change

Fixes: #940

The token balances dropdown was adding obligations to the total balance, this has been removed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

@elmurci
fix(account_page_header)
fa9e2f7 
The token balances dropdown was adding obligations to the total balance, this has been removed
@elmurci
chore(lint): fix linting
d383e41
@elmurci
chore: fix balances tests
5937f7a
mvadari
mvadari reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might require a larger conversation about how to convey these two separate pieces of information.

@elmurci
Copy link
Author

elmurci commented Feb 20, 2024 •
edited
Loading

This might require a larger conversation about how to convey these two separate pieces of information.

Agree.

@elmurci elmurci closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvadari mvadari mvadari left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Other balances" dropdown in account view shows wrong number
2 participants
@elmurci @mvadari